<html>
<head><meta charset="utf-8"><title>Turn off frame pointer elimination on aarch64_apple_darwin · t-compiler/wg-llvm · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/187780-t-compiler/wg-llvm/index.html">t-compiler/wg-llvm</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/187780-t-compiler/wg-llvm/topic/Turn.20off.20frame.20pointer.20elimination.20on.20aarch64_apple_darwin.html">Turn off frame pointer elimination on aarch64_apple_darwin</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="241176377"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187780-t-compiler/wg-llvm/topic/Turn%20off%20frame%20pointer%20elimination%20on%20aarch64_apple_darwin/near/241176377" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeff Muizelaar <a href="https://rust-lang.github.io/zulip_archive/stream/187780-t-compiler/wg-llvm/topic/Turn.20off.20frame.20pointer.20elimination.20on.20aarch64_apple_darwin.html#241176377">(Jun 02 2021 at 16:46)</a>:</h4>
<p>I'm looking for a reviewer for <a href="https://github.com/rust-lang/rust/pull/85706/files">https://github.com/rust-lang/rust/pull/85706/files</a>? Can anyone help with that or suggest a good person?</p>



<a name="241179533"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187780-t-compiler/wg-llvm/topic/Turn%20off%20frame%20pointer%20elimination%20on%20aarch64_apple_darwin/near/241179533" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeff Muizelaar <a href="https://rust-lang.github.io/zulip_archive/stream/187780-t-compiler/wg-llvm/topic/Turn.20off.20frame.20pointer.20elimination.20on.20aarch64_apple_darwin.html#241179533">(Jun 02 2021 at 17:11)</a>:</h4>
<p>thanks <span class="user-mention" data-user-id="123586">@nagisa</span></p>



<a name="241181306"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187780-t-compiler/wg-llvm/topic/Turn%20off%20frame%20pointer%20elimination%20on%20aarch64_apple_darwin/near/241181306" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeff Muizelaar <a href="https://rust-lang.github.io/zulip_archive/stream/187780-t-compiler/wg-llvm/topic/Turn.20off.20frame.20pointer.20elimination.20on.20aarch64_apple_darwin.html#241181306">(Jun 02 2021 at 17:25)</a>:</h4>
<p><span class="user-mention" data-user-id="123586">@nagisa</span> I'm a bit confused about what you want though. Do you want <code>eliminate_frame_pointer = false</code> moved into <a href="http://apple_base.rs">apple_base.rs</a> and removed from all of the places that use apple_base?</p>



<a name="241181627"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187780-t-compiler/wg-llvm/topic/Turn%20off%20frame%20pointer%20elimination%20on%20aarch64_apple_darwin/near/241181627" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nagisa <a href="https://rust-lang.github.io/zulip_archive/stream/187780-t-compiler/wg-llvm/topic/Turn.20off.20frame.20pointer.20elimination.20on.20aarch64_apple_darwin.html#241181627">(Jun 02 2021 at 17:27)</a>:</h4>
<p>Ah, I missed this is using a generic apple_base and not aarch64 specific apple_base. Fine to leave the code as is, then.</p>



<a name="241181755"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187780-t-compiler/wg-llvm/topic/Turn%20off%20frame%20pointer%20elimination%20on%20aarch64_apple_darwin/near/241181755" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nagisa <a href="https://rust-lang.github.io/zulip_archive/stream/187780-t-compiler/wg-llvm/topic/Turn.20off.20frame.20pointer.20elimination.20on.20aarch64_apple_darwin.html#241181755">(Jun 02 2021 at 17:28)</a>:</h4>
<p>Though it would still be good to find _some_ way to make sure this is shared between aarch64 apples somehow.</p>



<a name="241292122"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187780-t-compiler/wg-llvm/topic/Turn%20off%20frame%20pointer%20elimination%20on%20aarch64_apple_darwin/near/241292122" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nagisa <a href="https://rust-lang.github.io/zulip_archive/stream/187780-t-compiler/wg-llvm/topic/Turn.20off.20frame.20pointer.20elimination.20on.20aarch64_apple_darwin.html#241292122">(Jun 02 2021 at 17:34)</a>:</h4>
<p>Doesn't need to happen in this PR though.</p>



<a name="241292153"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187780-t-compiler/wg-llvm/topic/Turn%20off%20frame%20pointer%20elimination%20on%20aarch64_apple_darwin/near/241292153" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nagisa <a href="https://rust-lang.github.io/zulip_archive/stream/187780-t-compiler/wg-llvm/topic/Turn.20off.20frame.20pointer.20elimination.20on.20aarch64_apple_darwin.html#241292153">(Jun 02 2021 at 17:34)</a>:</h4>
<p>So if you'll just update the PR description its good to go.</p>



<a name="241292362"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187780-t-compiler/wg-llvm/topic/Turn%20off%20frame%20pointer%20elimination%20on%20aarch64_apple_darwin/near/241292362" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeff Muizelaar <a href="https://rust-lang.github.io/zulip_archive/stream/187780-t-compiler/wg-llvm/topic/Turn.20off.20frame.20pointer.20elimination.20on.20aarch64_apple_darwin.html#241292362">(Jun 02 2021 at 17:36)</a>:</h4>
<p><span class="user-mention" data-user-id="123586">@nagisa</span> I ended up making the change to just set it to false in apple_base and removing it from all the other places</p>



<a name="241292406"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187780-t-compiler/wg-llvm/topic/Turn%20off%20frame%20pointer%20elimination%20on%20aarch64_apple_darwin/near/241292406" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeff Muizelaar <a href="https://rust-lang.github.io/zulip_archive/stream/187780-t-compiler/wg-llvm/topic/Turn.20off.20frame.20pointer.20elimination.20on.20aarch64_apple_darwin.html#241292406">(Jun 02 2021 at 17:36)</a>:</h4>
<p>I'm pretty sure aarch64 darwin was the only place enabling it</p>



<a name="241294335"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187780-t-compiler/wg-llvm/topic/Turn%20off%20frame%20pointer%20elimination%20on%20aarch64_apple_darwin/near/241294335" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeff Muizelaar <a href="https://rust-lang.github.io/zulip_archive/stream/187780-t-compiler/wg-llvm/topic/Turn.20off.20frame.20pointer.20elimination.20on.20aarch64_apple_darwin.html#241294335">(Jun 02 2021 at 17:51)</a>:</h4>
<p><span class="user-mention" data-user-id="123586">@nagisa</span> updated</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>